[
https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894749#comment-15894749
]
ASF GitHub Bot commented on FLINK-5956:
---------------------------------------
GitHub user shaoxuan-wang opened a pull request:
https://github.com/apache/flink/pull/3470
[FLINK-5956] [table] Add retract method for aggregateFunction
This PR adds retraction method for AggregateFunction, it also implements
retract methods as well as test cases for all built-in aggregates.
Retraction method is help for processing update message. It will also very
helpful for the grouping window and over window aggregation where we may want
to retract the out of window data from the accumulator.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shaoxuan-wang/flink F5956-submit
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3470.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3470
----
commit 09a863bd70f4e8b693276e47942c1dff2fd5375e
Author: shaoxuan-wang <wshaox...@gmail.com>
Date: 2017-03-03T17:37:50Z
[FLINK-5956] [table] Add retract method for aggregateFunction
----
> Add retract method into the aggregateFunction
> ---------------------------------------------
>
> Key: FLINK-5956
> URL: https://issues.apache.org/jira/browse/FLINK-5956
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> Retraction method is help for processing updated message. It will also very
> helpful for window Aggregation. This PR will first add retraction methods
> into the aggregateFunctions, such that on-going over window Aggregation can
> get benefit from it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
