Github user WangTaoTheTonic commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3408#discussion_r104836285
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
    @@ -317,6 +319,10 @@ public AbstractYarnClusterDescriptor 
createDescriptor(String defaultApplicationN
                if (cmd.hasOption(SLOTS.getOpt())) {
                        int slots = 
Integer.valueOf(cmd.getOptionValue(SLOTS.getOpt()));
                        yarnClusterDescriptor.setTaskManagerSlots(slots);
    +           } else if (config.containsKey(ConfigConstants.YARN_VCORES)) {
    --- End diff --
    
    @tillrohrmann You mean YARN_VCORES is deprecated now? After checking code I 
found there're two places where we still use it: 
[here](https://github.com/apache/flink/blob/master/flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java#L317)
 and 
[here](https://github.com/apache/flink/blob/master/flink-yarn/src/main/java/org/apache/flink/yarn/YarnFlinkResourceManager.java#L339),
 especially the latter one is used for container request.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to