[ 
https://issues.apache.org/jira/browse/FLINK-5134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900933#comment-15900933
 ] 

ASF GitHub Bot commented on FLINK-5134:
---------------------------------------

Github user zhijiangW commented on the issue:

    https://github.com/apache/flink/pull/3455
  
    @StephanEwen , thank you for reviews and suggestions.
    
    I would add the related tests for `JobGraphGenerator` and try to cover 
different chained modes.
    
    BTW, I will also remove the previous comments for `setResources` public 
methods and change to private methods. So the tests can call them via 
reflection as mentioned in slack. What do you think?


> Aggregate ResourceSpec for chained operators when generating job graph
> ----------------------------------------------------------------------
>
>                 Key: FLINK-5134
>                 URL: https://issues.apache.org/jira/browse/FLINK-5134
>             Project: Flink
>          Issue Type: Sub-task
>          Components: DataStream API
>            Reporter: zhijiang
>            Assignee: zhijiang
>
> This is a part of fine-grained resource configuration in flip-6.
> In *JobGraph* generation, each *JobVertex* may contain a series of chained 
> operators, and the resource of *JobVertex* should be aggregation of 
> individual resource in chained operators.
> For memory resource in *JobVertex*, the aggregation is the sum formula for 
> chained operators, and for cpu cores resource, the aggregation is the maximum 
> formula for chained operators.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to