Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3501#discussion_r105406325
--- Diff:
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/DataStreamTest.java
---
@@ -906,6 +919,256 @@ public void testChannelSelectors() {
}
/////////////////////////////////////////////////////////////
+ // KeyBy testing
+ /////////////////////////////////////////////////////////////
+
+ @Rule
+ public ExpectedException expectedException = ExpectedException.none();
--- End diff --
Well it may be more concise, but a try catch block makes it way more
obvious that this part of the code throws an exception we care about.
try-catch blocks are also more commonin the codebase, and I'm wondering
whether we want to introduce an inconsistency there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
