Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3460#discussion_r105905806
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/MemoryArchivist.scala
---
@@ -183,6 +198,45 @@ class MemoryArchivist(private val max_entries: Int)
}
}
+ private def archiveJsonFiles(graph: ArchivedExecutionGraph) {
+ future {
+ try {
+ val rootPath = new Path(flinkConfiguration.getString(
--- End diff --
Since this has no default value, we need to check whether the path is null.
You should check this before submitting the future to safe work when no
directory is configured.
I get the following Exception in the logs:
```
2017-03-14 14:24:41,953 ERROR
org.apache.flink.runtime.jobmanager.MemoryArchivist - Failed to
archive job.
java.lang.IllegalArgumentException: Can not create a Path from a null string
at org.apache.flink.core.fs.Path.checkAndTrimPathArg(Path.java:159)
at org.apache.flink.core.fs.Path.<init>(Path.java:176)
at
org.apache.flink.runtime.jobmanager.MemoryArchivist$$anonfun$org$apache$flink$runtime$jobmanager$MemoryArchivist$$archiveJsonFiles$1.apply$mcV$sp(MemoryArchivist.scala:204)
at
org.apache.flink.runtime.jobmanager.MemoryArchivist$$anonfun$org$apache$flink$runtime$jobmanager$MemoryArchivist$$archiveJsonFiles$1.apply(MemoryArchivist.scala:203)
at
org.apache.flink.runtime.jobmanager.MemoryArchivist$$anonfun$org$apache$flink$runtime$jobmanager$MemoryArchivist$$archiveJsonFiles$1.apply(MemoryArchivist.scala:203)
at
scala.concurrent.impl.Future$PromiseCompletingRunnable.liftedTree1$1(Future.scala:24)
at
scala.concurrent.impl.Future$PromiseCompletingRunnable.run(Future.scala:24)
at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:40)
at
akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:397)
at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)
at
scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)
at
scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)
at
scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
