[ 
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926169#comment-15926169
 ] 

ASF GitHub Bot commented on FLINK-4460:
---------------------------------------

Github user kl0u commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3484#discussion_r106162749
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamEdge.java
 ---
    @@ -48,15 +49,25 @@
         * output selection).
         */
        private final List<String> selectedNames;
    +
    +   /**
    +    * The side-output tag (if any) of this {@link StreamEdge}.
    +    */
    +   private final OutputTag outputTag;
    +
    +   /**
    +    * The {@link StreamPartitioner} on this {@link StreamEdge}.
    +    */
        private StreamPartitioner<?> outputPartitioner;
     
        public StreamEdge(StreamNode sourceVertex, StreamNode targetVertex, int 
typeNumber,
    -                   List<String> selectedNames, StreamPartitioner<?> 
outputPartitioner) {
    +                   List<String> selectedNames, StreamPartitioner<?> 
outputPartitioner, OutputTag outputTag) {
                this.sourceVertex = sourceVertex;
                this.targetVertex = targetVertex;
                this.typeNumber = typeNumber;
                this.selectedNames = selectedNames;
                this.outputPartitioner = outputPartitioner;
    +           this.outputTag = outputTag;
     
    --- End diff --
    
    Does it make sense to add the outputTag also in the `edgeId`?


> Side Outputs in Flink
> ---------------------
>
>                 Key: FLINK-4460
>                 URL: https://issues.apache.org/jira/browse/FLINK-4460
>             Project: Flink
>          Issue Type: New Feature
>          Components: Core, DataStream API
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Chen Qin
>            Assignee: Chen Qin
>              Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to