Github user KurtYoung commented on a diff in the pull request:
https://github.com/apache/flink/pull/3520#discussion_r106322568
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -42,63 +41,40 @@ class DataSetCalc(
traitSet: RelTraitSet,
input: RelNode,
rowRelDataType: RelDataType,
- private[flink] val calcProgram: RexProgram, // for tests
+ calcProgram: RexProgram,
ruleDescription: String)
- extends SingleRel(cluster, traitSet, input)
+ extends Calc(cluster, traitSet, input, calcProgram)
--- End diff --
This is because i want to unify the PushFilterIntoScan rule's code for both
batch and stream mode. During executing the rule, we may need to create a new
copy of the DataSetCalc or DataStreamCalc. It make things more easier to let
these two classes inherit from `Calc`, and use `Calc.copy` to create a new
copied instance.
I do encountered some problem after i changed the hierarchy, some unit
tests failed because of the plan changed. But it's because we don't calculate
the cost for Calc right. I added some logic to `CommanCalc.computeSelfCost`,
and everything works fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
