Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3520
Thanks for the update @KurtYoung!
I think you have a good point about not extending `TableSourceScan`. The
filter pushdown flag might not be the only one. Let's keep this information in
`FilterableTableScan`.
I'm not so sure about the interface of `applyPredicate(predicates:
JList[Expression])`. I think we should not ask users to remove the accepted
Expressions from the `predicates` list. How about we add a method
`getPredicates(): JList[Expression]` which returns the accepted expressions.
This method could also replace `isFilterPushedDown` if we expect `null` if
`getPredicates()` was not called and an empty list if it was called but no
predicate was accepted. IMO, `getPredicates()` has also the advantage that we
can check that the `FilterableTableSource` did not modify the accepted
predicates.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
