[
https://issues.apache.org/jira/browse/FLINK-5413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15932903#comment-15932903
]
ASF GitHub Bot commented on FLINK-5413:
---------------------------------------
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3565#discussion_r106939897
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/TableTestBase.scala
---
@@ -151,21 +152,31 @@ case class BatchTableTestUtil() extends TableTestUtil
{
verifyTable(tEnv.sql(query), expected)
}
- def verifyTable(resultTable: Table, expected: String): Unit = {
+ def verifyTable(resultTable: Table, expected: String, tableEnv:
BatchTableEnv): Unit = {
--- End diff --
I think once we move the `from`, `to` tests to a runtime ITCase we don't
need the changes to the TableTestBase anymore.
> Convert TableEnvironmentITCases to unit tests
> ---------------------------------------------
>
> Key: FLINK-5413
> URL: https://issues.apache.org/jira/browse/FLINK-5413
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: GaoLun
>
> The following IT cases could be converted into unit tests:
> - {{org.apache.flink.table.api.scala.batch.TableEnvironmentITCase}}
> - {{org.apache.flink.table.api.java.batch.TableEnvironmentITCase}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
