Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3574#discussion_r106996212
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +317,465 @@ class SqlITCase extends StreamingWithStateTestBase {
result.addSink(new StreamITCase.StringSink)
env.execute()
}
+
+ /**
+ *
+ * //////////////////////////////////////////////////////
+ * START TESTING BOUNDED PROC TIME ROW AGGREGATIO
+ * //////////////////////////////////////////////////////
+ *
+ */
+
+ @Test
+ def testUnpartitionedMaxAggregatation(): Unit = {
--- End diff --
Many of these tests test the same feature with different aggregation
functions.
Since the aggregation functions are separately tested, I'd suggest to
restrict the tests to four different configurations of OVER windows:
1. multiple aggregations, partitioned, 2 rows preceding
2. multiple aggregations, partitioned, 4 rows preceding
3. multiple aggregations, non-partitioned, 2 rows preceding
4. multiple aggregations, non-partitioned, 10 rows preceding
This should give us good coverage of the feature.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
