[
https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15936306#comment-15936306
]
ASF GitHub Bot commented on FLINK-6034:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3531#discussion_r107409859
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyGroupsStateHandle.java
---
@@ -91,10 +98,10 @@ public KeyGroupsStateHandle
getKeyGroupIntersection(KeyGroupRange keyGroupRange)
/**
*
- * @return the internal key-group range to offsets metadata
+ * @return the start key group in the key-group range of this handle
*/
- public KeyGroupRangeOffsets getGroupRangeOffsets() {
- return groupRangeOffsets;
+ public int getStartKeyGroup() {
--- End diff --
I suggest to remove this pass-through method, as it at a very low
abstraction level. This information can be obtained already from the result of
`getKeyGroupRange()`. Now, that we expose the `KeyGroupRange`, also
`getNumberOfKeyGroups()` could be removed, as we can ask the `KeyGroupRange`
directly.
> Add KeyedStateHandle for the snapshots in keyed streams
> -------------------------------------------------------
>
> Key: FLINK-6034
> URL: https://issues.apache.org/jira/browse/FLINK-6034
> Project: Flink
> Issue Type: Sub-task
> Components: State Backends, Checkpointing
> Reporter: Xiaogang Shi
> Assignee: Xiaogang Shi
>
> Currently, the only type of the snapshots in keyed streams is
> {{KeyGroupsStateHandle}} which is full and store the states one group after
> another. With the introduction of incremental checkpointing, we need a higher
> level abstraction of keyed snapshots to allow flexible snapshot formats.
> The implementation of {{KeyedStateHandle}} s may vary a lot in different
> backends. The only information needed in {{KeyedStateHandle}} s is their key
> group range. When recovering the job with a different degree of parallelism,
> {{KeyedStateHandle}} s will be assigned to those subtasks whose key group
> ranges overlap with their ranges.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
