Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3409#discussion_r107103482
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/logical/operators.scala
 ---
    @@ -511,15 +511,15 @@ case class Join(
     }
     
     case class CatalogNode(
    -    tableName: String,
    -    rowType: RelDataType) extends LeafNode {
    +    rowType: RelDataType,
    +    tablePath: String*) extends LeafNode {
    --- End diff --
    
    I agree with @twalthr on this one. Varargs are nice syntactic sugar for 
APIs but internally, we should rather use arrays.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to