Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3585#discussion_r107672464
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
@@ -91,6 +91,55 @@ object AggregateUtil {
}
/**
+ * Create an
[[org.apache.flink.streaming.api.functions.ProcessFunction]] for ROWS clause
+ * bounded OVER window to evaluate final aggregate value.
+ *
+ * @param namedAggregates List of calls to aggregate functions and
their output field names
+ * @param inputType Input row type
+ * @param inputFields All input fields
+ * @param precedingOffset the preceding offset
+ * @param isRowTimeType It is a tag that indicates whether the time
type is rowTimeType
+ * @param isPartitioned It is a tag that indicates whether the data
has partitioned
+ * @return [[org.apache.flink.streaming.api.functions.ProcessFunction]]
+ */
+ private[flink] def createRowsClauseBoundedOverProcessFunction(
+ namedAggregates: Seq[CalcitePair[AggregateCall, String]],
+ inputType: RelDataType,
+ inputFields: Array[Int],
+ precedingOffset: Long,
+ isRowTimeType: Boolean,
+ isPartitioned: Boolean = true): ProcessFunction[Row, Row] = {
+
+ val (aggFields, aggregates) =
+ transformToAggregateFunctions(
+ namedAggregates.map(_.getKey),
+ inputType,
+ needRetraction = true)
+
+ val aggregationStateType: RowTypeInfo =
+ createDataSetAggregateBufferDataType(Array(), aggregates, inputType)
+
+ if (isPartitioned) {
--- End diff --
Do we need to distinguish this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
