Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3585#discussion_r107707653
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala
---
@@ -317,4 +397,24 @@ class SqlITCase extends StreamingWithStateTestBase {
result.addSink(new StreamITCase.StringSink)
env.execute()
}
+
+}
+
+object SqlITCase {
+
+ class TimestampWithLatenessWatermark(allowedLateness: Long)
--- End diff --
I don't think we need this timestamp extractor. IMO, the offset should be
integrated into the window operator itself and not rely on modified watermarks.
I'd suggest to first add this OVER window operator without offset support
and add this later when the other OVER window operators have been added.
What do you think, @shaoxuan-wang and @sunjincheng121 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
