[
https://issues.apache.org/jira/browse/FLINK-6183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940943#comment-15940943
]
ASF GitHub Bot commented on FLINK-6183:
---------------------------------------
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3611
[backport] [FLINK-6183]/[FLINK-6184] Prevent some NPE and unclosed metric
groups
Backport of #3610 for 1.2 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6183_6184_metric_task_backport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3611.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3611
----
commit 790b3ce444e10191731850bad71c35fe050d9af3
Author: zentol <ches...@apache.org>
Date: 2017-03-24T18:11:58Z
[FLINK-6184] Prevent NPE in buffer metrics
commit 13e40466ffe63783c59cc979900ba7af2d693576
Author: zentol <ches...@apache.org>
Date: 2017-03-24T18:39:31Z
[FLINK-6183] [metrics] Prevent some cases of TaskMG not being closed
----
> TaskMetricGroup may not be cleanup when Task.run() is never called or exits
> early
> ---------------------------------------------------------------------------------
>
> Key: FLINK-6183
> URL: https://issues.apache.org/jira/browse/FLINK-6183
> Project: Flink
> Issue Type: Bug
> Components: Metrics
> Affects Versions: 1.2.0, 1.3.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Blocker
>
> The TaskMetricGroup is created when a Task is created. It is cleaned up at
> the end of Task.run() in the finally block. If however run() is never called
> due some failure between the creation and the call to run the metric group is
> never closed. This also means that the JobMetricGroup is never closed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
