[
https://issues.apache.org/jira/browse/FLINK-4523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15946588#comment-15946588
]
ASF GitHub Bot commented on FLINK-4523:
---------------------------------------
Github user tsriharsha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2916#discussion_r108598516
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/KinesisConfigUtil.java
---
@@ -215,4 +229,18 @@ private static void
validateOptionalPositiveDoubleProperty(Properties config, St
}
}
}
+
+ private static void validateOptionalDateProperty(Properties config,
String key, String message) {
+ if (config.containsKey(key)) {
+ try {
+
initTimestampDateFormat.parse(config.getProperty(key));
--- End diff --
Hey this throws an error if a double is passed but the next line throws an
exception when a timestamp string is passed. @tzulitai @tony810430
> Allow Kinesis Consumer to start from specific timestamp / Date
> --------------------------------------------------------------
>
> Key: FLINK-4523
> URL: https://issues.apache.org/jira/browse/FLINK-4523
> Project: Flink
> Issue Type: New Feature
> Components: Kinesis Connector
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Wei-Che Wei
> Fix For: 1.3.0
>
>
> We had a Kinesis user requesting this feature on an offline chat.
> To be specific, we let all initial Kinesis shards be iterated starting from
> records at the given timestamp.
> The AWS Java SDK we're using already provides API for this, so we can add
> this functionality with fairly low overhead:
> http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/kinesis/model/GetShardIteratorRequest.html#setTimestamp-java.util.Date-
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
