Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3661
Thanks for opening this PR. ð
I had a few comments and I think it's easier to collect them here instead
of commenting on the individual files:
- I would prefer to not call `context.getCurrent*Time()` overtime even
though it's not needed. This can be costly. Instead we can pass the `Context`
and only invoke the methods when needed.
- I regard `WindowOperatorTest` as legacy, new tests should be added to
`WindowOperatorContractTest`. This is a base class with a lot of test cases
that is extended by `RegularWindowOperatorTest` and
`EvictingWindowOperatorTest`.
Both of these are hard to know and it's not obvious what test should go
where, sorry for the inconvenience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
