[
https://issues.apache.org/jira/browse/FLINK-6246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953558#comment-15953558
]
ASF GitHub Bot commented on FLINK-6246:
---------------------------------------
Github user dawidwys commented on a diff in the pull request:
https://github.com/apache/flink/pull/3662#discussion_r109428555
--- Diff:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
---
@@ -619,20 +619,20 @@ public void collect(StreamRecord<T> record) {
}
@Override
- public <X> void collect(OutputTag<?> outputTag, StreamRecord<X>
record) {
+ public <X> void collect(OutputTag<X> outputTag, StreamRecord<X>
record) {
for (int i = 0; i < outputs.length - 1; i++) {
Output<StreamRecord<T>> output = outputs[i];
// due to side outputs, StreamRecords of
varying types can pass through the broadcasting
// collector so we need to cast
@SuppressWarnings({"unchecked", "rawtypes"})
--- End diff --
Suppression not needed anymore. Also the comment is not adequate, as we do
not cast anything.
> Fix generic type of OutputTag in operator Output
> ------------------------------------------------
>
> Key: FLINK-6246
> URL: https://issues.apache.org/jira/browse/FLINK-6246
> Project: Flink
> Issue Type: Bug
> Components: DataStream API
> Reporter: Aljoscha Krettek
>
> The current signature is
> {code}
> <X> void collect(OutputTag<?> outputTag, StreamRecord<X> record)
> {code}
> which can be improved to
> {code}
> <X> void collect(OutputTag<X> outputTag, StreamRecord<X> record)
> {code}
> This is probably leftover from an intermediate stage of development.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
