[ 
https://issues.apache.org/jira/browse/FLINK-4848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957731#comment-15957731
 ] 

ASF GitHub Bot commented on FLINK-4848:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/3677

    [FLINK-4848] [ssl] Throw meaningful exception when SSL is misconfigured

    This PR provides better error messages when SSL is enabled but is missing 
crucial configuration options.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 4848_ssl_npe

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3677
    
----

----


> keystoreFilePath should be checked against null in 
> SSLUtils#createSSLServerContext
> ----------------------------------------------------------------------------------
>
>                 Key: FLINK-4848
>                 URL: https://issues.apache.org/jira/browse/FLINK-4848
>             Project: Flink
>          Issue Type: Bug
>          Components: Security
>            Reporter: Ted Yu
>            Assignee: Chesnay Schepler
>            Priority: Minor
>
> {code}
>       String keystoreFilePath = sslConfig.getString(
>         ConfigConstants.SECURITY_SSL_KEYSTORE,
>         null);
> ...
>       try {
>         keyStoreFile = new FileInputStream(new File(keystoreFilePath));
> {code}
> If keystoreFilePath is null, the File ctor would throw NPE.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to