[
https://issues.apache.org/jira/browse/FLINK-6270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15958536#comment-15958536
]
ASF GitHub Bot commented on FLINK-6270:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3683#discussion_r110104138
--- Diff:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java ---
@@ -595,6 +595,35 @@ public boolean containsKey(String key){
}
}
+ /**
+ * Checks whether there is an entry for the given config option
+ *
+ * @param configOption The configuration option
+ *
+ * @return <tt>true</tt> if a valid (current of deprecated) key of the
config option is stored,
+ * <tt>false</tt> otherwise
+ */
+ public boolean contains(ConfigOption<?> configOption) {
--- End diff --
Could you annotate this with `@PublicEvolving` similar to other methods
using `ConfigOption`s.
> Port several network config parameters to ConfigOption
> ------------------------------------------------------
>
> Key: FLINK-6270
> URL: https://issues.apache.org/jira/browse/FLINK-6270
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.3.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Minor
>
> I'd like to port some memory and network buffers related config options to
> new {{ConfigOption}} instances before continuing with FLINK-4545. These
> include:
> * {{taskmanager.memory.size}}
> * {{taskmanager.memory.fraction}}
> * {{taskmanager.memory.off-heap}}
> * {{taskmanager.memory.preallocate}}
> * {{taskmanager.network.numberOfBuffers}}
> * {{taskmanager.memory.segment-size}}
> Some of these already existed as {{ConfigOption}} instances in
> {{MiniClusterConfiguration}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
