[
https://issues.apache.org/jira/browse/FLINK-4953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15962178#comment-15962178
]
ASF GitHub Bot commented on FLINK-4953:
---------------------------------------
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3661
I'm currently in SF for http://sf.flink-forward.org and quite busy. That's
why my responses are quite slow, sorry for that.
A quick answer: There is the (slightly hard to find)
`InternalWindowFunctionTest` which tests that the internal window functions
correctly forward calls to a process window function and other (user facing)
window functions. We should test the internal logic of the new time access code
for `InternalWindowFunction` in `WindowOperatorContractTest`, (see, for example
`testPerWindowStateSetAndClearedOnEventTimePurge()`). We should add more tests
that verify that per-window state and also the new time access is correctly
forwarded in `InternalWindowFunctionTest`.
What do you think?
> Allow access to "time" in ProcessWindowFunction.Context
> -------------------------------------------------------
>
> Key: FLINK-4953
> URL: https://issues.apache.org/jira/browse/FLINK-4953
> Project: Flink
> Issue Type: Improvement
> Components: DataStream API
> Reporter: Manu Zhang
> Assignee: Manu Zhang
>
> The recently added {{ProcessWindowFunction}} has a {{Context}} object that
> allows querying some additional information about the window firing that we
> are processing. Right now, this is only the window for which the firing is
> happening. We should extends this with methods that allow querying the
> current processing time and the current watermark.
> Original text by issue creator: This is similar to FLINK-3674 but exposing
> time information in window functions. Currently when a timer is fired, all
> states in a window will be returned to users, including those after the
> timer. This change will allow users to filter out states after the timer
> based on time info.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
