[
https://issues.apache.org/jira/browse/FLINK-6143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964524#comment-15964524
]
ASF GitHub Bot commented on FLINK-6143:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3710
[FLINK-6143] [clients] Fix unprotected access to this.flink in LocalE…
…xecutor#endSession.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink_6143
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3710.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3710
----
commit 83904c4e736d17cb32ffcbf1d2f90b5521837284
Author: zhangminglei <[email protected]>
Date: 2017-04-11T15:29:50Z
[FLINK-6143] [clients] Fix unprotected access to this.flink in
LocalExecutor#endSession.
----
> Unprotected access to this.flink in LocalExecutor#endSession()
> --------------------------------------------------------------
>
> Key: FLINK-6143
> URL: https://issues.apache.org/jira/browse/FLINK-6143
> Project: Flink
> Issue Type: Bug
> Components: Client
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> public void endSession(JobID jobID) throws Exception {
> LocalFlinkMiniCluster flink = this.flink;
> if (flink != null) {
> {code}
> The flink field is not declared volatile and access to this.flink doesn't
> hold the LocalExecutor.lock
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
