[
https://issues.apache.org/jira/browse/FLINK-6090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15967501#comment-15967501
]
ASF GitHub Bot commented on FLINK-6090:
---------------------------------------
Github user hequn8128 commented on the issue:
https://github.com/apache/flink/pull/3696
hi @fhueske , Thanks for your review and refactorings. I think it's pretty
good and I have learned a lot form it. I left a few comments in your PR.
As for the hardcode problem, I think you are right, it's better to extend
the DataStreamRel with a couple of methods. I have added some methods in
DataStreamRel, so you can use them directly when you squash your PR into my
commit, thx~
> Add RetractionRule at the stage of decoration
> ---------------------------------------------
>
> Key: FLINK-6090
> URL: https://issues.apache.org/jira/browse/FLINK-6090
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Hequn Cheng
>
> Implement optimizer for retraction:
> 1.Add RetractionRule at the stage of decoration，which can derive the
> replace table/append table, NeedRetraction property.
> 2.Match the NeedRetraction and replace table, mark the accumulating mode
>
> When this task is finished, we can turn on retraction for different operators
> according to accumulating mode.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
