[
https://issues.apache.org/jira/browse/FLINK-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970358#comment-15970358
]
ASF GitHub Bot commented on FLINK-6104:
---------------------------------------
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/3725
[FLINK-6104] Fix resource leak in ListViaRangeSpeedMiniBenchmark.
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira
title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6104
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3725.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3725
----
commit 0ff43539f76ec7f87b45fba6e27541487a37c78e
Author: zhangminglei <zml13856086...@163.com>
Date: 2017-04-16T12:10:21Z
[FLINK-6104] Fix resource leak in ListViaRangeSpeedMiniBenchmark.
----
> Resource leak in ListViaRangeSpeedMiniBenchmark
> -----------------------------------------------
>
> Key: FLINK-6104
> URL: https://issues.apache.org/jira/browse/FLINK-6104
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Reporter: Ted Yu
> Assignee: mingleizhang
> Priority: Minor
>
> {code}
> final WriteOptions write_options = new WriteOptions()
> .setSync(false)
> .setDisableWAL(true);
> {code}
> WriteOptions ultimately extends AbstractNativeReference where:
> {code}
> public abstract class AbstractNativeReference implements AutoCloseable {
> {code}
> WriteOptions instance should be closed.
> {code}
> final RocksDB rocksDB = RocksDB.open(options, rocksDir.getAbsolutePath());
> {code}
> RocksDB should be closed as well.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
