[
https://issues.apache.org/jira/browse/FLINK-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972723#comment-15972723
]
ASF GitHub Bot commented on FLINK-6091:
---------------------------------------
Github user lincoln-lil commented on a diff in the pull request:
https://github.com/apache/flink/pull/3733#discussion_r111959008
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamGroupWindowAggregate.scala
---
@@ -107,6 +107,14 @@ class DataStreamGroupWindowAggregate(
val groupingKeys = grouping.indices.toArray
val inputDS =
input.asInstanceOf[DataStreamRel].translateToPlan(tableEnv)
+ val consumeRetraction = DataStreamRetractionRules.isAccRetract(input)
+
+ if (consumeRetraction) {
+ throw new TableException(
+ "Retraction on group window is not supported yet. Note: Currently,
group window should " +
+ "not follow an unbounded groupby.")
--- End diff --
1. 'is not supported yet' -> 'unsupported yet' maybe more concisely.
2. groupby -> groupBy
> Implement and turn on the retraction for aggregates
> ---------------------------------------------------
>
> Key: FLINK-6091
> URL: https://issues.apache.org/jira/browse/FLINK-6091
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Hequn Cheng
>
> Implement functions for generating and consuming retract messages for
> different aggregates.
> 1. add delete/add property to Row
> 2. implement functions for generating retract messages for unbounded groupBy
> 3. implement functions for handling retract messages for different aggregates.
> 4. handle retraction messages in CommonCorrelate and CommonCalc (retain
> Delete property).
> Note: Currently, only unbounded groupby generates retraction and it is
> working under unbounded and processing time mode. Hence, retraction is only
> supported for unbounded and processing time aggregations so far. We can add
> more retraction support later.
> supported now: unbounded groupby, unbounded and processing time over window
> unsupported now: group window, event time or bounded over window.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
