Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3541#discussion_r112071560
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/SubEvent.java ---
    @@ -31,6 +31,18 @@ public double getVolume() {
        }
     
        @Override
    +   public boolean equals(Object obj) {
    +           return obj instanceof SubEvent &&
    +                           super.equals(obj) &&
    +                           ((SubEvent) obj).volume == volume;
    +   }
    +
    +   @Override
    +   public int hashCode() {
    +           return super.hashCode() + (int) volume;
    --- End diff --
    
    Common practice is to multiply super.hashCode() by a prime (e.g. 37)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to