[ 
https://issues.apache.org/jira/browse/FLINK-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973569#comment-15973569
 ] 

ASF GitHub Bot commented on FLINK-6032:
---------------------------------------

Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3541#discussion_r112071560
  
    --- Diff: 
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/SubEvent.java ---
    @@ -31,6 +31,18 @@ public double getVolume() {
        }
     
        @Override
    +   public boolean equals(Object obj) {
    +           return obj instanceof SubEvent &&
    +                           super.equals(obj) &&
    +                           ((SubEvent) obj).volume == volume;
    +   }
    +
    +   @Override
    +   public int hashCode() {
    +           return super.hashCode() + (int) volume;
    --- End diff --
    
    Common practice is to multiply super.hashCode() by a prime (e.g. 37)


> CEP-Clean up the operator state when not needed.
> ------------------------------------------------
>
>                 Key: FLINK-6032
>                 URL: https://issues.apache.org/jira/browse/FLINK-6032
>             Project: Flink
>          Issue Type: Bug
>          Components: CEP
>    Affects Versions: 1.3.0
>            Reporter: Kostas Kloudas
>            Assignee: Kostas Kloudas
>             Fix For: 1.3.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to