Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3733#discussion_r112065725
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala
 ---
    @@ -129,11 +131,17 @@ class DataStreamOverAggregate(
                 generator,
                 inputDS,
                 isRowTimeType = false,
    -            isRowsClause = overWindow.isRows)
    +            isRowsClause = overWindow.isRows,
    +            consumeRetraction)
    --- End diff --
    
    I think it would be better to enable retraction for all types of OVER 
aggregates at the same time. 
    Just supporting one specific type adds more confusion than it helps, in my 
opinion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to