[
https://issues.apache.org/jira/browse/FLINK-888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14043640#comment-14043640
]
ASF GitHub Bot commented on FLINK-888:
--------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/44#discussion_r14194380
--- Diff:
stratosphere-java/src/test/java/eu/stratosphere/api/java/tuple/Tuple2Test.java
---
@@ -0,0 +1,55 @@
+/***********************************************************************************************************************
+ *
+ * Copyright (C) 2010-2013 by the Stratosphere project
(http://stratosphere.eu)
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may
not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on
+ * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
express or implied. See the License for the
+ * specific language governing permissions and limitations under the
License.
+ *
+
**********************************************************************************************************************/
+
+package eu.stratosphere.api.java.tuple;
+
+import junit.framework.Assert;
+
+import org.junit.Before;
+import org.junit.Test;
+
+public class Tuple2Test {
+
+ private Tuple2<String, Integer> classUnderTestTuple2;
+
+ @Before
+ public void setUp() throws Exception {
+ classUnderTestTuple2 = new Tuple2<String, Integer>(new
String("Test case"), 25);
--- End diff --
I would suggest to just move this tuple to the `testSwapValues()` method
since you only use it there. I also think the name is rather verbose.
> Add swap() method to Tuple2
> ---------------------------
>
> Key: FLINK-888
> URL: https://issues.apache.org/jira/browse/FLINK-888
> Project: Flink
> Issue Type: Improvement
> Reporter: GitHub Import
> Assignee: Tobias
> Labels: github-import
> Fix For: pre-apache
>
>
> In line with Scala
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/888
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: enhancement, java api,
> Milestone: Release 0.6 (unplanned)
> Created at: Thu May 29 14:49:49 CEST 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.2#6252)
