Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/42#discussion_r14508952
  
    --- Diff: 
stratosphere-compiler/src/main/java/eu/stratosphere/compiler/operators/MapPartitionDescriptor.java
 ---
    @@ -0,0 +1,60 @@
    
+/***********************************************************************************************************************
    + * Copyright (C) 2010-2013 by the Stratosphere project 
(http://stratosphere.eu)
    + *
    + * Licensed under the Apache License, Version 2.0 (the "License"); you may 
not use this file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software 
distributed under the License is distributed on
    + * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either 
express or implied. See the License for the
    + * specific language governing permissions and limitations under the 
License.
    + 
**********************************************************************************************************************/
    +
    +package eu.stratosphere.compiler.operators;
    +
    +import java.util.Collections;
    +import java.util.List;
    +
    +import eu.stratosphere.compiler.dag.SingleInputNode;
    +import eu.stratosphere.compiler.dataproperties.GlobalProperties;
    +import eu.stratosphere.compiler.dataproperties.LocalProperties;
    +import eu.stratosphere.compiler.dataproperties.RequestedGlobalProperties;
    +import eu.stratosphere.compiler.dataproperties.RequestedLocalProperties;
    +import eu.stratosphere.compiler.plan.Channel;
    +import eu.stratosphere.compiler.plan.SingleInputPlanNode;
    +import eu.stratosphere.pact.runtime.task.DriverStrategy;
    +
    +
    +public class MapPartitionDescriptor extends OperatorDescriptorSingle {
    +
    +   @Override
    +   public DriverStrategy getStrategy() {
    +           return DriverStrategy.MAP;
    --- End diff --
    
    This needs to be MAP_PARTITION.
    
    In your code, I guess the strategy is never taken from here, but still, 
this is a setup for future bugs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to