Github user fhueske commented on the pull request:
https://github.com/apache/incubator-flink/pull/45#issuecomment-48152087
Looks good, but one last thing. Can you extract the parameter handling and
usage descriptions to a separate private method as done in the other examples.
The purpose is to reduce the boilerplate code in the main method such that it
only contains code which is relevant for the example.
After that you can squash the commits and push with force to your PR
branch. The PR will be automatically updated. Please do also a rebase to the
latest master.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
