[
https://issues.apache.org/jira/browse/FLINK-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14064824#comment-14064824
]
ASF GitHub Bot commented on FLINK-629:
--------------------------------------
GitHub user gyfora opened a pull request:
https://github.com/apache/incubator-flink/pull/73
[FLINK-629] getFieldNotNull added to Tuple and updated operators
Operators which use key comparisons now use getFieldNotNull for getting the
key fields, which will throw NullKeyFieldException if the key is null.
Aggregators are also updated to use getFieldNotNull and will throw a
NullFieldExceptions if the field is null.
The TupleSerializer now throws NullFieldException when it encounters a null
field it cannot serialize instead of a NullPointerException.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gyfora/incubator-flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/73.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #73
----
commit e5cc6a4724ebfeac4dcef8faffe1cbe3c0dcacf0
Author: gyfora <[email protected]>
Date: 2014-07-16T17:09:04Z
[FLINK-629] getFieldNotNull added to Tuple and updated Aggregators and
Comparators to use that where appropriate
commit 337dd967528d6cf65d317561d4aa0cd38edb70b7
Author: mbalassi <[email protected]>
Date: 2014-07-17T07:49:53Z
[FLINK-629] Updated getFieldNotNull usage and added it to TupleSerializers
----
> Add support for null values to the java api
> -------------------------------------------
>
> Key: FLINK-629
> URL: https://issues.apache.org/jira/browse/FLINK-629
> Project: Flink
> Issue Type: Improvement
> Components: Java API
> Reporter: Stephan Ewen
> Assignee: Gyula Fora
> Priority: Critical
> Labels: github-import
> Fix For: pre-apache
>
>
> Currently, many runtime operations fail when encountering a null value. Tuple
> serialization should allow null fields.
> I suggest to add a method to the tuples called `getFieldNotNull()` which
> throws a meaningful exception when the accessed field is null. That way, we
> simplify the logic of operators that should not dead with null fields, like
> key grouping or aggregations.
> Even though SQL allows grouping and aggregating of null values, I suggest to
> exclude this from the java api, because the SQL semantics of aggregating null
> fields are messy.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/629
> Created by: [StephanEwen|https://github.com/StephanEwen]
> Labels: enhancement, java api,
> Milestone: Release 0.5.1
> Created at: Wed Mar 26 00:27:49 CET 2014
> State: open
--
This message was sent by Atlassian JIRA
(v6.2#6252)
