Github user uce commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/77#discussion_r15227373
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/memorymanager/AbstractMemorySegmentOutputView.java
---
@@ -0,0 +1,337 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.memorymanager;
+
+import java.io.IOException;
+import java.io.UTFDataFormatException;
+
+import org.apache.flink.core.memory.DataInputView;
+import org.apache.flink.core.memory.DataOutputView;
+import org.apache.flink.core.memory.MemorySegment;
+
+/**
+ * The base class for all output views that are backed by multiple memory
pages. This base class contains all
+ * encoding methods to write data to a page and detect page boundary
crossing. The concrete sub classes must
+ * implement {@link #advance()} for moving through the memory segments and
the tell/seek related methods
+ * from {@link org.apache.flink.core.memory.DataOutputView}.
+ * <p>
+ * The paging assumes that all memory segments are of the same size.
+ */
+public abstract class AbstractMemorySegmentOutputView implements
DataOutputView {
+ protected final int segmentSize; // the
size of the memory segments
+ protected final int headerLength; // the
number of bytes to skip at the beginning of each segment
+ protected MemorySegment currentSegment; // the current
memory segment to write to
+ protected int positionInSegment;
// the offset in the current segment
+ private byte[] utfBuffer;
// the reusable array for UTF encodings
--- End diff --
Oh :laughing: I think with comments spaces should be fine, but checkstyle
could complain.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
