Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/37#discussion_r15515720
--- Diff:
flink-addons/flink-hadoop-compatibility/src/test/java/org/apache/flink/test/hadoopcompatibility/mapred/driver/HadoopWordCountVariations.java
---
@@ -0,0 +1,316 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.test.hadoopcompatibility.mapred.driver;
+
+
+import org.apache.flink.hadoopcompatibility.mapred.FlinkHadoopJobClient;
+import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.io.IntWritable;
+import org.apache.hadoop.io.LongWritable;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.io.WritableComparable;
+import org.apache.hadoop.io.WritableComparator;
+import org.apache.hadoop.mapred.JobConf;
+import org.apache.hadoop.mapred.MapReduceBase;
+import org.apache.hadoop.mapred.Mapper;
+import org.apache.hadoop.mapred.OutputCollector;
+import org.apache.hadoop.mapred.Reporter;
+import org.apache.hadoop.mapred.TextOutputFormat;
+import org.apache.hadoop.mapred.lib.HashPartitioner;
+import org.apache.hadoop.mapred.lib.LongSumReducer;
+import org.apache.hadoop.mapred.lib.TokenCountMapper;
+
+import java.io.IOException;
+import java.util.Iterator;
+
+public class HadoopWordCountVariations {
+
+ public static class TestTokenizeMap<K> extends TokenCountMapper<K> {
+ @Override
+ public void map(K key, Text value, OutputCollector<Text,
LongWritable> output, Reporter reporter)
+ throws IOException {
+ final Text strippedValue = new
Text(value.toString().toLowerCase().replaceAll("\\W+", " "));
+ super.map(key, strippedValue, output, reporter);
+ }
+ }
+
+ public static class NonGenericInputFormat {
+
+ public static void main(String[] args) throws Exception {
+ final String inputPath = args[0];
+ final String outputPath = args[1];
+
+ final JobConf conf = new JobConf();
+
+ conf.setInputFormat(CustomTextInputFormat.class);
+
org.apache.hadoop.mapred.TextInputFormat.addInputPath(conf, new
Path(inputPath));
+
+ conf.setOutputFormat(TextOutputFormat.class);
+ TextOutputFormat.setOutputPath(conf, new
Path(outputPath));
+
+ conf.setMapperClass(TestTokenizeMap.class);
+ conf.setReducerClass(LongSumReducer.class);
+ conf.setCombinerClass((LongSumReducer.class));
+
+ conf.set("mapred.textoutputformat.separator", " ");
+ conf.setOutputKeyClass(Text.class);
+ conf.setOutputValueClass(LongWritable.class);
+
+ FlinkHadoopJobClient.runJob(conf);
+ }
+
+ public static class CustomTextInputFormat extends
org.apache.hadoop.mapred.TextInputFormat {
+ }
+ }
+
+ public static class StringTokenizer {
+
+ public static void main(String[] args) throws Exception {
+ final String inputPath = args[0];
+ final String outputPath = args[1];
+
+ final JobConf conf = new JobConf();
+
+
conf.setInputFormat(org.apache.hadoop.mapred.TextInputFormat.class);
+
org.apache.hadoop.mapred.TextInputFormat.addInputPath(conf, new
Path(inputPath));
+
+ conf.setOutputFormat(TextOutputFormat.class);
+ TextOutputFormat.setOutputPath(conf, new
Path(outputPath));
+
+ conf.setMapperClass(TestTokenizeMap.class);
+
+
+ conf.set("mapred.textoutputformat.separator", " ");
+ conf.setOutputKeyClass(Text.class);
+ conf.setOutputValueClass(LongWritable.class);
+
+ FlinkHadoopJobClient.runJob(conf);
+ }
+ }
+
+ public static class WordCountCustomGroupingComparator {
+
+ public static void main(String[] args) throws Exception {
+ final String inputPath = args[0];
+ final String outputPath = args[1];
+
+ final JobConf conf = new JobConf();
+
+
conf.setInputFormat(org.apache.hadoop.mapred.TextInputFormat.class);
+
org.apache.hadoop.mapred.TextInputFormat.addInputPath(conf, new
Path(inputPath));
+
+ conf.setOutputFormat(TextOutputFormat.class);
+ TextOutputFormat.setOutputPath(conf, new
Path(outputPath));
+
+ conf.setMapperClass(TestTokenizeMap.class);
+ conf.setReducerClass(LongSumReducer.class);
+ conf.setCombinerClass((LongSumReducer.class));
+
conf.setOutputValueGroupingComparator(FirstLetterComparator.class);
+
+ conf.set("mapred.textoutputformat.separator", " ");
+ conf.setOutputKeyClass(Text.class);
+ conf.setOutputValueClass(LongWritable.class);
+
+ FlinkHadoopJobClient.runJob(conf);
+ }
+
+ //First Letters only.
+ public static class FirstLetterComparator extends
WritableComparator {
+
+ public FirstLetterComparator() {
+ super(Text.class, true);
+ }
+
+ @Override
+ public int compare(WritableComparable t1,
WritableComparable t2) {
+ final Text key1 = (Text) t1;
+ final IntWritable key1Char = new
IntWritable(key1.charAt(0));
+ final Text key2 = (Text) t2;
+ final IntWritable key2Char = new
IntWritable(key2.charAt(0));
+ return key1Char.compareTo(key2Char);
+ }
+ }
+ }
+
+ public static class WordCountCustomPartitioner {
+ public static void main(String[] args) throws Exception {
+ final String inputPath = args[0];
+ final String outputPath = args[1];
+
+ final JobConf conf = new JobConf();
+
+
conf.setInputFormat(org.apache.hadoop.mapred.TextInputFormat.class);
+
org.apache.hadoop.mapred.TextInputFormat.addInputPath(conf, new
Path(inputPath));
+
+ conf.setOutputFormat(TextOutputFormat.class);
+ TextOutputFormat.setOutputPath(conf, new
Path(outputPath));
+
+ conf.setMapperClass(TestTokenizeMap.class);
+ conf.setReducerClass(LongSumReducer.class);
+ conf.setCombinerClass((LongSumReducer.class));
+ conf.setPartitionerClass(MyPartitioner.class);
+ conf.setNumReduceTasks(5); //Will be ignored!
+
+ conf.set("mapred.textoutputformat.separator", " ");
+ conf.setOutputKeyClass(Text.class);
+ conf.setOutputValueClass(LongWritable.class);
+
+ FlinkHadoopJobClient.runJob(conf);
+ }
+
+
+ public static class MyPartitioner<Text, LongWritable> extends
HashPartitioner<Text, LongWritable> {
+
+ @Override
+ public int getPartition(Text key, LongWritable value,
int numReduceTasks) {
+ return 0;
+ }
+ }
+ }
+
+ public static class WordCountDifferentCombiner {
+
+ public static void main(String[] args) throws Exception {
+ final String inputPath = args[0];
+ final String outputPath = args[1];
+
+ final JobConf conf = new JobConf();
+
+
conf.setInputFormat(org.apache.hadoop.mapred.TextInputFormat.class);
+
org.apache.hadoop.mapred.TextInputFormat.addInputPath(conf, new
Path(inputPath));
+
+ conf.setOutputFormat(TextOutputFormat.class);
+ TextOutputFormat.setOutputPath(conf, new
Path(outputPath));
+
+ conf.setMapperClass(TestTokenizeMap.class);
+ conf.setCombinerClass((LongSumReducer.class));
+ conf.setReducerClass(TestReducer.class);
--- End diff --
Use a Reducer that is not derived from the combiner and has different
return types to check if the combiner/reducer type handling is correct.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
