[
https://issues.apache.org/jira/browse/FLINK-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133993#comment-14133993
]
Robert Metzger edited comment on FLINK-1055 at 9/15/14 3:15 PM:
----------------------------------------------------------------
The title of the issue says "JM Webfrontend", whereas JM means Job manager ;)
I think there is a test case in the compiler to verify that the JSON for the
webclient is valid. ("DumpCompiledPlanTest").
I would like to have tests that check if the JSON of the jobmanager webfrontend
is valid. So if the system is able to generate for example the json for the job
history view (list & detailed).
The test would cover if:
- there are no exceptions on the way of generating it
- that it shows the expected results
- that the JSON is valid.
The same applies to the log view and task manager list.
[~StephanEwen] wrote a lot of new tests for the JobManager. Maybe you can
piggy-back on them to save some work. His work is not yet merged in the master,
but I think his work should be finished this week.
I would suggest to wait until Stephan has finished his changes.
was (Author: rmetzger):
The title of the issue says "JM Webfrontend", whereas JM means Job manager ;)
I think there is a test case in the compiler to verify that the JSON for the
webclient is valid. ("DumpCompiledPlanTest").
I would like to have tests that check if the JSON of the jobmanager webfrontend
is valid. So if the system is able to generate for example the json for the job
history view (list & detailed).
The test would cover if:
- there are no exceptions on the way of generating it
- that it shows the expected results
- that the JSON is valid.
The same applies to the log view and task manager list.
[~StephanEwen] wrote a lot of new tests for the JobManager. Maybe you can
piggy-back on them to save some work. His work is not yet merged in the master,
but I think his work should be finished this week.
I would suggest to wait until Stephan has finished his work.
> JM Webfrontend needs unit tests
> -------------------------------
>
> Key: FLINK-1055
> URL: https://issues.apache.org/jira/browse/FLINK-1055
> Project: Flink
> Issue Type: Improvement
> Components: Webfrontend
> Reporter: Robert Metzger
> Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There are currently no tests that validate if the generated JSON is valid (or
> if the frontend is actually able to generate the JSONs).
> We had too many bugs in the past related to the web frontend. In addition to
> that, it is a lot of work to manually test it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
