Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/141#discussion_r18435533
  
    --- Diff: 
flink-compiler/src/test/java/org/apache/flink/compiler/WorksetIterationsJavaApiCompilerTest.java
 ---
    @@ -78,7 +78,7 @@ public void 
testJavaApiWithDeferredSoltionSetUpdateWithMapper() {
                        // verify joinWithSolutionSet
                        assertEquals(ShipStrategyType.PARTITION_HASH, 
joinWithSolutionSetNode.getInput1().getShipStrategy());
                        assertEquals(ShipStrategyType.FORWARD, 
joinWithSolutionSetNode.getInput2().getShipStrategy());
    -                   assertEquals(new FieldList(0, 1), 
joinWithSolutionSetNode.getKeysForInput1());
    --- End diff --
    
    Does this indicate that you found and fixed another bug on the way 
(screwing up fields orders through the sorting?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to