[ 
https://issues.apache.org/jira/browse/FLINK-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159569#comment-14159569
 ] 

ASF GitHub Bot commented on FLINK-1032:
---------------------------------------

Github user rmetzger commented on the pull request:

    https://github.com/apache/incubator-flink/pull/141#issuecomment-57940493
  
    Thank you for the thorough review. I'll address the issues.
    
    Regarding the serializer test, there is the `PojoSerializerTest extends 
SerializerTestBase<PojoSerializerTest.TestUserClass>`. It is doing 12 tests 
(copy, instantiation, etc).
    I'll look into the Tuple Serializer tests and see what I can do for the 
PojoSerializer. But there are definitively tests for the comparator missing.


> Extend POJO Field Selectors to Support Accessing Nested Objects
> ---------------------------------------------------------------
>
>                 Key: FLINK-1032
>                 URL: https://issues.apache.org/jira/browse/FLINK-1032
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Java API
>            Reporter: Aljoscha Krettek
>            Assignee: Robert Metzger
>
> Right now you can only use fields of the top-level object as key fields in 
> groupings, joins, and co-group. This should be extended to allow using nested 
> fields. We have to be careful with null fields, though.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to