Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/158#discussion_r19032254
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/LocatableInputSplitAssigner.java
---
@@ -173,13 +175,13 @@ public LocatableInputSplit getNextInputSplit(String
host) {
}
}
- private static final boolean isLocal(String host, String[] hosts) {
- if (host == null || hosts == null) {
+ private static final boolean isLocal(String flinkHost, String[] hosts) {
+ if (flinkHost == null || hosts == null) {
return false;
}
-
for (String h : hosts) {
--- End diff --
I would add some null checks here. Input Splits are user generated an can
contained arbitrary nonsense in general
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
