Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/35#issuecomment-59584807
Cool, the tests are a good start! I think it would be very good to add the
following cases, that are tricky for the dependency visitor:
- An anonymous inner class in a **static** method that accesses a local
variable in its closure
- An anonymous inner class in a **non-static** method that accesses a
local variable in its closure
- An anonymous inner class in a non-static method that accesses a field
of the enclosing object
- An anonymous inner class in an anonymous inner class that that accesses
a field of the outermost enclosing object
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
