Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/172#discussion_r19725427
  
    --- Diff: 
flink-addons/flink-hbase/src/main/java/org/apache/flink/addons/hbase/TableInputFormat.java
 ---
    @@ -179,26 +155,13 @@ protected Scan createScanner(Configuration 
parameters) {
         *        a {@link Configuration} that holds at least the table name.
         */
        protected HTable createTable(Configuration parameters) {
    -           String configLocation = 
parameters.getString(TableInputFormat.CONFIG_LOCATION, null);
    -           LOG.info("Got config location: " + configLocation);
    -           if (configLocation != null)
    -           {
    -                   org.apache.hadoop.conf.Configuration dummyConf = new 
org.apache.hadoop.conf.Configuration();
    -                   if(OperatingSystem.isWindows()) {
    -                           dummyConf.addResource(new Path("file:/" + 
configLocation));
    -                   } else {
    -                           dummyConf.addResource(new Path("file://" + 
configLocation));
    -                   }
    -                   hConf = HBaseConfiguration.create(dummyConf);
    -                   ;
    -                   // hConf.set("hbase.master", 
"im1a5.internetmemory.org");
    -                   LOG.info("hbase master: " + hConf.get("hbase.master"));
    -                   LOG.info("zookeeper quorum: " + 
hConf.get("hbase.zookeeper.quorum"));
    -
    -           }
    +           LOG.info("Initializing HBaseConfiguration");
    +           //use files found in the classpath
    +           org.apache.hadoop.conf.Configuration hConf = 
HBaseConfiguration.create();
    --- End diff --
    
    Have you checked if using an empty configuration is working in a 
distributed setting? 
    Where does the hostname of the HBase master come from? Is it maybe using a 
default value (localhost) which works on in a local setup only?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to