[
https://issues.apache.org/jira/browse/FLINK-1218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14200717#comment-14200717
]
ASF GitHub Bot commented on FLINK-1218:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/183#issuecomment-62036117
Virtually all cases are tests, where it makes no matter. One case can be
entirely avoided.
I think skipping the calls entirely and just letting the autoboxing do its
magic (it uses Integer.valueOf() as well) would be even nicer.
All in all the fix is fine, though.
> Don't use "new Integer". Use "Integer.valueOf" instead.
> -------------------------------------------------------
>
> Key: FLINK-1218
> URL: https://issues.apache.org/jira/browse/FLINK-1218
> Project: Flink
> Issue Type: Bug
> Affects Versions: 0.8-incubating
> Reporter: Kousuke Saruta
>
> There are lots of "new Integer" or something line it in the code.
> We should use valueOf to avoid wasted instance creation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
