[
https://issues.apache.org/jira/browse/FLINK-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212314#comment-14212314
]
ASF GitHub Bot commented on FLINK-337:
--------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/202#discussion_r20361691
--- Diff: flink-dist/src/main/flink-bin/bin/flink ---
@@ -48,6 +48,7 @@ CC_CLASSPATH=`manglePathList
$(constructCLIClientClassPath)`
log=$FLINK_LOG_DIR/flink-$FLINK_IDENT_STRING-flink-client-$HOSTNAME.log
log_setting="-Dlog.file="$log"
-Dlog4j.configuration=file:"$FLINK_CONF_DIR"/log4j.properties
-Dlogback.configurationFile=file:"$FLINK_CONF_DIR"/logback.xml"
+export FLINK_ROOT_DIR
--- End diff --
I've been unsure about this change for a long time, wondering whether i
should instead export only a specific directory. The python package currently
resides in /resource/python, is there a more appropriate place to put it?
> Fixed all JavaDoc warnings in pact-common.
> ------------------------------------------
>
> Key: FLINK-337
> URL: https://issues.apache.org/jira/browse/FLINK-337
> Project: Flink
> Issue Type: Bug
> Reporter: GitHub Import
> Labels: github-import
> Fix For: pre-apache
>
> Attachments: pull-request-337-8997712741697485992.patch
>
>
> Fixed all JavaDoc warnings in pact-common.
> I focused on fixing the build warnings but also added and updated some
> JavaDoc on the way.
> Adresses issue
> ([#330|https://github.com/stratosphere/stratosphere/issues/330] |
> [FLINK-330|https://issues.apache.org/jira/browse/FLINK-330]).
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/pull/337
> Created by: [fhueske|https://github.com/fhueske]
> Labels:
> Created at: Wed Dec 11 17:50:03 CET 2013
> State: closed
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
