[
https://issues.apache.org/jira/browse/FLINK-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14212753#comment-14212753
]
ASF GitHub Bot commented on FLINK-1208:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20382587
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/DataSourceTask.java
---
@@ -192,8 +192,9 @@ public void invoke() throws Exception {
// as long as there is
data to read
while
(!this.taskCanceled && !format.reachedEnd()) {
// build next
pair and ship pair if it is valid
- if ((record =
format.nextRecord(record)) != null) {
-
output.collect(record);
+ OT r;
--- End diff --
These modifications change Flink's behavior for any type of InputFormat,
not just CSVInputFormats.
If we want to allow to skip invalid lines, this is not the right place to
add this feature.
> Skip comment lines in CSV input format. Allow user to specify comment
> character.
> --------------------------------------------------------------------------------
>
> Key: FLINK-1208
> URL: https://issues.apache.org/jira/browse/FLINK-1208
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
> Affects Versions: 0.8-incubating
> Reporter: Aljoscha Krettek
> Assignee: Felix Neutatz
> Priority: Minor
> Labels: starter
>
> The current skipFirstLine is limited. Skipping arbitrary lines that start
> with a certain character would be much more flexible while still easy to
> implement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
