[
https://issues.apache.org/jira/browse/FLINK-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14214573#comment-14214573
]
ASF GitHub Bot commented on FLINK-1244:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/205#issuecomment-63294764
Looks good.
I assume that this is breaking binary compatibility, though. Source
compatibility is preserved.
+1 to merge it.
> setCombinable() clunky to use
> -----------------------------
>
> Key: FLINK-1244
> URL: https://issues.apache.org/jira/browse/FLINK-1244
> Project: Flink
> Issue Type: Wish
> Components: Java API
> Affects Versions: 0.7.0-incubating
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Trivial
> Labels: starter
>
> Setting the combinable property for a GroupReduce manually is a bit clunky,
> since setCombinable() doesn't return the operator.
> A wordcount would look like this:
> {code:java}
> GroupReduceOperator output = source
> .map...
> .groupBy(1)
> .reduceGroup...;
> output.setCombinable(true);
> output.print();
> {code}
> whereas this would be more convenient
> {code:java}
> source
> .map...
> .groupBy(1)
> .reduceGroup...
> .setCombinale(true)
> .print();
> {code}
> is there a reason for it not returning the operator?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
