[
https://issues.apache.org/jira/browse/FLINK-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14217701#comment-14217701
]
ASF GitHub Bot commented on FLINK-1208:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20567259
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/GenericCsvInputFormat.java
---
@@ -279,6 +308,7 @@ protected boolean parseRecord(Object[] holders, byte[]
bytes, int offset, int nu
// check valid start position
if (startPos >= limit) {
if (lenient) {
+ LOG.warn("The invalid line: \"" + new
String(bytes, offset, numBytes) + "\" was skipped.");
--- End diff --
In order to make it more efficient with deactivated logging, we guard such
statements with `if (LOG.isWarnEnabled()) { LOG.warn(...); }` Otherwise, the
string concatenation will happen even with deactivated logging.
> Skip comment lines in CSV input format. Allow user to specify comment
> character.
> --------------------------------------------------------------------------------
>
> Key: FLINK-1208
> URL: https://issues.apache.org/jira/browse/FLINK-1208
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
> Affects Versions: 0.8-incubating
> Reporter: Aljoscha Krettek
> Assignee: Felix Neutatz
> Priority: Minor
> Labels: starter
>
> The current skipFirstLine is limited. Skipping arbitrary lines that start
> with a certain character would be much more flexible while still easy to
> implement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
