Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/221#discussion_r20637988
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/iterative/io/SerializedUpdateBuffer.java
---
@@ -259,7 +261,7 @@ public ReadEnd switchBuffers() throws IOException {
private final LinkedBlockingQueue<MemorySegment>
emptyBufferTarget;
- private final ArrayDeque<MemorySegment> fullBufferSource;
--- End diff --
I sometimes strongly type the fields to the collection implementation
(rather than the interface) in performance critical parts.
That way, we can make strong assumptions on the complexity of certain
operations (such as random access is constant in an ArrayList is constant, vs
linear in a LinkedList).
I think that this in not crucial here, but in general, not all such
declared occurrences are accidental.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
