[ 
https://issues.apache.org/jira/browse/FLINK-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220798#comment-14220798
 ] 

ASF GitHub Bot commented on FLINK-1019:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/149#discussion_r20710194
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/minicluster/FlinkMiniCluster.scala
 ---
    @@ -0,0 +1,121 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.minicluster
    +
    +import java.util.concurrent.TimeUnit
    +
    +import akka.pattern.ask
    +import akka.actor.{ActorRef, ActorSystem}
    +import org.apache.flink.configuration.{ConfigConstants, Configuration}
    +import org.apache.flink.runtime.akka.AkkaUtils
    +import 
org.apache.flink.runtime.messages.TaskManagerMessages.NotifyWhenRegisteredAtJobManager
    +import org.slf4j.LoggerFactory
    +
    +import scala.concurrent.duration.FiniteDuration
    +import scala.concurrent.{Future, Await}
    +
    +abstract class FlinkMiniCluster(userConfiguration: Configuration) {
    --- End diff --
    
    The user config argument is a great idea. I was checking this, because I 
need something similar for my changes. I will add a similar thing to my branch 
for now.


> Rework RPC service
> ------------------
>
>                 Key: FLINK-1019
>                 URL: https://issues.apache.org/jira/browse/FLINK-1019
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Runtime
>            Reporter: Ufuk Celebi
>
> There is work going on to improve the RPC service by using [Akka|akka.io]. I 
> couldn't find a issue for it.
> Could one of the two people working on it ([~StephanEwen] and [~asteriosk]) 
> please give an overview of the changes and a status update?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to