[
https://issues.apache.org/jira/browse/FLINK-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14222144#comment-14222144
]
ASF GitHub Bot commented on FLINK-1208:
---------------------------------------
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/201#discussion_r20759425
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/io/CsvInputFormat.java ---
@@ -117,10 +177,36 @@ public void open(FileInputSplit split) throws
IOException {
if (this.getDelimiter().length == 1 && this.getDelimiter()[0]
== '\n' ) {
this.lineDelimiterIsLinebreak = true;
}
+
+ this.commentCount = 0;
+ this.invalidLineCount = 0;
+
+ isLogged = false;
+ }
+
+ @Override
+ public OUT nextRecord(OUT record) throws IOException {
+ OUT returnrecord = super.nextRecord(record);
+ if (reachedEnd() && !isLogged) {
--- End diff --
Can we move this to the `close()` method? Method? Would keep this method a
bit tighter...
> Skip comment lines in CSV input format. Allow user to specify comment
> character.
> --------------------------------------------------------------------------------
>
> Key: FLINK-1208
> URL: https://issues.apache.org/jira/browse/FLINK-1208
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
> Affects Versions: 0.8-incubating
> Reporter: Aljoscha Krettek
> Assignee: Felix Neutatz
> Priority: Minor
> Labels: starter
>
> The current skipFirstLine is limited. Skipping arbitrary lines that start
> with a certain character would be much more flexible while still easy to
> implement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
