Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/incubator-flink/pull/227#discussion_r20788520
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/typeutils/ValueTypeInfo.java
---
@@ -131,7 +127,7 @@ public String toString() {
//
--------------------------------------------------------------------------------------------
- static final <X extends Value> TypeInformation<X>
getValueTypeInfo(Class<X> typeClass) {
--- End diff --
The `final` modifiers in are technically redundant on such methods (as they
are on private methods). To me, they still sort of express an intent that the
logic is the function is a hard assumption that should not be easily swapped
for something else. This, the modifier is a soft documentation token...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
