[
https://issues.apache.org/jira/browse/FLINK-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224317#comment-14224317
]
ASF GitHub Bot commented on FLINK-1208:
---------------------------------------
Github user aljoscha commented on the pull request:
https://github.com/apache/incubator-flink/pull/201#issuecomment-64355493
I don't like the name of the method: "enableComments()". It does not enable
comments, what would that even mean. In my opinion it should be called
"ignoreComments()".
Also, there is no support for this in the Scala API. We could add it by
adding an optional parameter to readCsvFile(), like this:
```scala
def readCsvFile[T <: Product : ClassTag : TypeInformation](
filePath: String,
lineDelimiter: String = "\n",
fieldDelimiter: Char = ',',
ignoreFirstLine: Boolean = false,
ignoreComments: String = null,
lenient: Boolean = false,
includedFields: Array[Int] = null): DataSet[T] = {
```
> Skip comment lines in CSV input format. Allow user to specify comment
> character.
> --------------------------------------------------------------------------------
>
> Key: FLINK-1208
> URL: https://issues.apache.org/jira/browse/FLINK-1208
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Scala API
> Affects Versions: 0.8-incubating
> Reporter: Aljoscha Krettek
> Assignee: Felix Neutatz
> Priority: Minor
> Labels: starter
>
> The current skipFirstLine is limited. Skipping arbitrary lines that start
> with a certain character would be much more flexible while still easy to
> implement.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
